FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
118 11 0 0

info.limpet.ui.data_provider.data.DataManagerDropAdapter

Bug Category Details Line Priority
instanceof will always return true for all non-null values in info.limpet.ui.data_provider.data.DataManagerDropAdapter.performDrop(Object), since all info.limpet.IStoreGroup are instances of info.limpet.IStoreGroup STYLE BC_VACUOUS_INSTANCEOF 117 Medium

info.limpet.ui.data_provider.data.ReflectivePropertySource

Bug Category Details Line Priority
info.limpet.ui.data_provider.data.ReflectivePropertySource.getPropertyDescriptors() may expose internal representation by returning ReflectivePropertySource.propertyDescriptors MALICIOUS_CODE EI_EXPOSE_REP 81 Medium

info.limpet.ui.editors.DataManagerEditor

Bug Category Details Line Priority
info.limpet.ui.editors.DataManagerEditor.editorContextMenuAboutToShow(IMenuManager) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 698 Medium

info.limpet.ui.editors.DataManagerEditor$ViewerKeyAdapter

Bug Category Details Line Priority
Should info.limpet.ui.editors.DataManagerEditor$ViewerKeyAdapter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 132 Medium

info.limpet.ui.editors.dnd.DataManagerDropAdapter

Bug Category Details Line Priority
Return value of String.endsWith(String) ignored in info.limpet.ui.editors.dnd.DataManagerDropAdapter.filesDropped(String[]) CORRECTNESS RV_RETURN_VALUE_IGNORED 213 Medium

info.limpet.ui.heatmap.Helper2D

Bug Category Details Line Priority
info.limpet.ui.heatmap.Helper2D.titleFor(List) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 398 Medium

info.limpet.ui.propertyeditors.SliderCellEditor

Bug Category Details Line Priority
Primitive value is boxed then unboxed to perform primitive coercion in info.limpet.ui.propertyeditors.SliderCellEditor.doSetValue(Object) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION 155 Medium

info.limpet.ui.range_slider.RangeSliderView$DateIndexHelper

Bug Category Details Line Priority
Primitive value is boxed and then immediately unboxed in new info.limpet.ui.range_slider.RangeSliderView$DateIndexHelper(RangeSliderView, Long, Long, String, IStoreGroup, NumberDocument) PERFORMANCE BX_BOXING_IMMEDIATELY_UNBOXED 84 Medium
new info.limpet.ui.range_slider.RangeSliderView$DateIndexHelper(RangeSliderView, Long, Long, String, IStoreGroup, NumberDocument) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 84 Medium
Should info.limpet.ui.range_slider.RangeSliderView$DateIndexHelper be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 74 Medium

info.limpet.ui.xy_plot.XyPlotView

Bug Category Details Line Priority
Useless object stored in variable safeColl of method info.limpet.ui.xy_plot.XyPlotView.showIndexedQuantity(List) STYLE UC_USELESS_OBJECT 500 Medium