FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
182 28 0 0

Files

Class Bugs
info.limpet.analysis.GeneralDescription$MilliFormatter 1
info.limpet.analysis.GeneralDescription$NumberFormatter 1
info.limpet.analysis.GeneralDescription$SecondFormatter 1
info.limpet.impl.Document$DoubleIterator 1
info.limpet.impl.NumberDocument$DoubleIterator 2
info.limpet.impl.Range 1
info.limpet.impl.SampleData 1
info.limpet.impl.SampleData$ObjectColl 1
info.limpet.impl.StoreGroup 2
info.limpet.operations.AbstractCommand 2
info.limpet.operations.admin.CreateNewLookupDatafileOperation 1
info.limpet.operations.arithmetic.BinaryQuantityOperation$BinaryQuantityCommand 1
info.limpet.operations.arithmetic.BulkQuantityOperation$BulkQuantityCommand 1
info.limpet.operations.arithmetic.InterpolatedMaths 1
info.limpet.operations.arithmetic.simple.AddQuantityOperation$AddQuantityValues 1
info.limpet.operations.arithmetic.simple.MultiplyQuantityOperation$MultiplyQuantityValues 1
info.limpet.operations.grid.GenerateGrid$GenerateGridCommand 1
info.limpet.persistence.rep.RepParser 6
info.limpet.persistence.rep.RepParser$Item$CutItem 1
info.limpet.persistence.rep.RepParser$Item$FixItem 1

info.limpet.analysis.GeneralDescription$MilliFormatter

Bug Category Details Line Priority
Should info.limpet.analysis.GeneralDescription$MilliFormatter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 46 Medium

info.limpet.analysis.GeneralDescription$NumberFormatter

Bug Category Details Line Priority
Should info.limpet.analysis.GeneralDescription$NumberFormatter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 68 Medium

info.limpet.analysis.GeneralDescription$SecondFormatter

Bug Category Details Line Priority
Should info.limpet.analysis.GeneralDescription$SecondFormatter be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 57 Medium

info.limpet.impl.Document$DoubleIterator

Bug Category Details Line Priority
info.limpet.impl.Document$DoubleIterator.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 333 Medium

info.limpet.impl.NumberDocument$DoubleIterator

Bug Category Details Line Priority
new info.limpet.impl.NumberDocument$DoubleIterator(double[]) may expose internal representation by storing an externally mutable object into NumberDocument$DoubleIterator._data MALICIOUS_CODE EI_EXPOSE_REP2 30 Medium
info.limpet.impl.NumberDocument$DoubleIterator.next() can't throw NoSuchElementException BAD_PRACTICE IT_NO_SUCH_ELEMENT 43 Medium

info.limpet.impl.Range

Bug Category Details Line Priority
info.limpet.impl.Range defines equals and uses Object.hashCode() BAD_PRACTICE HE_EQUALS_USE_HASHCODE 44 High

info.limpet.impl.SampleData

Bug Category Details Line Priority
Integral division result cast to double or float in info.limpet.impl.SampleData.getData(long) STYLE ICAST_IDIV_CAST_TO_DOUBLE 228 Medium

info.limpet.impl.SampleData$ObjectColl

Bug Category Details Line Priority
Class info.limpet.impl.SampleData$ObjectColl defines non-transient non-serializable instance field _predecessor BAD_PRACTICE SE_BAD_FIELD Medium

info.limpet.impl.StoreGroup

Bug Category Details Line Priority
info.limpet.impl.StoreGroup.getTime() may expose internal representation by returning StoreGroup._currentTime MALICIOUS_CODE EI_EXPOSE_REP 301 Medium
info.limpet.impl.StoreGroup.setTime(Date) may expose internal representation by storing an externally mutable object into StoreGroup._currentTime MALICIOUS_CODE EI_EXPOSE_REP2 308 Medium

info.limpet.operations.AbstractCommand

Bug Category Details Line Priority
Nullcheck of times at line 420 of value previously dereferenced in info.limpet.operations.AbstractCommand.locationsFor(LocationDocument, double[], CollectionComplianceTests$TimePeriod) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 410 High
Nullcheck of times at line 523 of value previously dereferenced in info.limpet.operations.AbstractCommand.numbersFor(NumberDocument, double[], CollectionComplianceTests$TimePeriod) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 513 High

info.limpet.operations.admin.CreateNewLookupDatafileOperation

Bug Category Details Line Priority
info.limpet.operations.admin.CreateNewLookupDatafileOperation.actionsFor(List, IStoreGroup, IContext) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 197 Medium

info.limpet.operations.arithmetic.BinaryQuantityOperation$BinaryQuantityCommand

Bug Category Details Line Priority
Potentially ambiguous invocation of either an outer or inherited method info.limpet.operations.arithmetic.CoreQuantityCommand.getATests() in info.limpet.operations.arithmetic.BinaryQuantityOperation$BinaryQuantityCommand.performCalc() STYLE IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD 245 Medium

info.limpet.operations.arithmetic.BulkQuantityOperation$BulkQuantityCommand

Bug Category Details Line Priority
Potentially ambiguous invocation of either an outer or inherited method info.limpet.operations.arithmetic.CoreQuantityCommand.getATests() in info.limpet.operations.arithmetic.BulkQuantityOperation$BulkQuantityCommand.performCalc() STYLE IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD 240 Medium

info.limpet.operations.arithmetic.InterpolatedMaths

Bug Category Details Line Priority
instanceof will always return true for all non-null values in info.limpet.operations.arithmetic.InterpolatedMaths.performWithInterpolation(Dataset, Dataset, Dataset, InterpolatedMaths$IOperationPerformer), since all org.eclipse.january.dataset.Dataset are instances of org.eclipse.january.dataset.IDataset STYLE BC_VACUOUS_INSTANCEOF 350 Medium

info.limpet.operations.arithmetic.simple.AddQuantityOperation$AddQuantityValues

Bug Category Details Line Priority
info.limpet.operations.arithmetic.simple.AddQuantityOperation$AddQuantityValues.getBulkNameFor(List) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 69 Medium

info.limpet.operations.arithmetic.simple.MultiplyQuantityOperation$MultiplyQuantityValues

Bug Category Details Line Priority
info.limpet.operations.arithmetic.simple.MultiplyQuantityOperation$MultiplyQuantityValues.getBulkNameFor(List) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 58 Medium

info.limpet.operations.grid.GenerateGrid$GenerateGridCommand

Bug Category Details Line Priority
new info.limpet.operations.grid.GenerateGrid$GenerateGridCommand(String, String, IStoreGroup, List, IContext, GenerateGrid$Triplet, double[], GenerateGrid$DataProcessor) may expose internal representation by storing an externally mutable object into GenerateGrid$GenerateGridCommand.bins MALICIOUS_CODE EI_EXPOSE_REP2 63 Medium

info.limpet.persistence.rep.RepParser

Bug Category Details Line Priority
Dead store to lastPartOfName in info.limpet.persistence.rep.RepParser.checkForQuotedName(StringTokenizer, String) STYLE DLS_DEAD_LOCAL_STORE 391 Medium
Dead store to txtLabel in info.limpet.persistence.rep.RepParser.parseThisRepLine(String) STYLE DLS_DEAD_LOCAL_STORE 606 Medium
Redundant nullcheck of labelTxt, which is known to be non-null in info.limpet.persistence.rep.RepParser.parseThisSensor2(String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 945 Medium
Call to method of static java.text.DateFormat in info.limpet.persistence.rep.RepParser.parseThis(String) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 455 Medium
Call to method of static java.text.DateFormat in info.limpet.persistence.rep.RepParser.parseThis(String) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 459 Medium
info.limpet.persistence.rep.RepParser.parse(String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 781 Medium

info.limpet.persistence.rep.RepParser$Item$CutItem

Bug Category Details Line Priority
new info.limpet.persistence.rep.RepParser$Item$CutItem(String, String, Point2D, Date, Double, Double, Double, Double, String) may expose internal representation by storing an externally mutable object into RepParser$Item$CutItem._dtg MALICIOUS_CODE EI_EXPOSE_REP2 279 Medium

info.limpet.persistence.rep.RepParser$Item$FixItem

Bug Category Details Line Priority
new info.limpet.persistence.rep.RepParser$Item$FixItem(Date, Point2D, double, double, double, String, String) may expose internal representation by storing an externally mutable object into RepParser$Item$FixItem._date MALICIOUS_CODE EI_EXPOSE_REP2 315 Medium